Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boundary in RGB_MATRIX_INDICATOR_SET_COLOR #18650

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Fix boundary in RGB_MATRIX_INDICATOR_SET_COLOR #18650

merged 3 commits into from
Oct 11, 2022

Conversation

thomsj
Copy link
Contributor

@thomsj thomsj commented Oct 9, 2022 •
edited
Loading

Description

  • Exclude index equal to led_max as it is 1 greater than the index of the last/max LED.
  • Update Markdown examples which use <= led_max.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@thomsj
Fix boundary in RGB_MATRIX_INDICATOR_SET_COLOR
50f634a 
Exclude index equal to `led_max` as it is 1 greater than the index of
the last/max LED.
@github-actions github-actions bot added the core label Oct 9, 2022
@drashna drashna requested a review from a team October 10, 2022 00:57
fauxpark
fauxpark requested changes Oct 10, 2022
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also be done for LED Matrix.

@thomsj
Copy link
Contributor Author

thomsj commented Oct 10, 2022

Should also be done for LED Matrix.

I couldn't find an equivalent for LED Matrix. Did you mean in /quantum/led_matrix/led_matrix.h or /quantum/led_matrix/led_matrix.c?

@zvecr
Copy link
Member

zvecr commented Oct 10, 2022

LED_MATRIX_INDICATOR_SET_VALUE

@thomsj
Copy link
Contributor Author

thomsj commented Oct 10, 2022

Thank you @zvecr.

I can only find LED_MATRIX_INDICATOR_SET_VALUE in feature_led_matrix.md.

I've also searched for LED_MATRIX_INDICATOR_SET_VALUE in the Git history, but can't find it in any other file.

@fauxpark
Copy link
Member

If it doesn't exist, then don't worry about it.

@drashna drashna merged commit 4115932 into qmk:develop Oct 11, 2022
@thomsj thomsj deleted the fix-RGB_MATRIX_INDICATOR_SET_COLOR branch October 11, 2022 22:49
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@thomsj @ramonimbao
Fix boundary in RGB_MATRIX_INDICATOR_SET_COLOR (qmk#18650)
df0330a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomsj @zvecr @fauxpark @drashna